Bug 30340
| Summary: | Make fast/css/opacity-float.html use the script-test approach | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Evan Martin <evan> |
| Component: | Tools / Tests | Assignee: | Evan Martin <evan> |
| Status: | NEW | ||
| Severity: | Normal | CC: | krit |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Evan Martin
Darin says:
In the future, you should use the script-tests approach to build tests like
this. This style of tests that write out more about what they're testing and
why they pass that you get automatically from that are superior. A good example
of how to do this sort of test is
LayoutTests/fast/dom/HTMLFormElement/script-tests/elements-not-in-document.js
and you may be able to see from that how this test could have been done that
way.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Evan Martin
Also, while I'm fixing it:
> - change the test to use script-tests for better clarity
> - add quite a few more kinds of numbers to the test cases
> - test all the different types of units -- a test should fail if we made
> any mistakes in the switch statements
I guess that maybe should be a new test, which is a general "test CSS unit formatting" test.