Bug 303398
| Summary: | [RenderStyleGen] Generate getter/setter functions that were missed due to being implemented in RenderStyle.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, lmoura, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 303504 | ||
Sam Weinig
A few properties were missed due to their implementations being inline in RenderStyle.h.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/54710
EWS
Committed 303805@main (8aa1e5bdbca5): <https://commits.webkit.org/303805@main>
Reviewed commits have been landed. Closing PR #54710 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/165733843>
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/54827
Diego Pino
The 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot fails with the following error:
https://build.webkit.org/#/builders/46/builds/58096/steps/9/logs/stdio
```
WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h: In member function ‘constexpr bool WebCore::RenderStyle::isDisplayRegionType() const’:
WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h:228:19: error: call to non-‘constexpr’ function ‘WebCore::DisplayType WebCore::RenderStyle::display() const’
228 | return display() == DisplayType::Block
```
GCC12 and lower are more strict with regard to declaration of functions as constexpr.
Lauro Moura
*** Bug 303504 has been marked as a duplicate of this bug. ***
EWS
Committed 303918@main (aa9410d1ed64): <https://commits.webkit.org/303918@main>
Reviewed commits have been landed. Closing PR #54827 and removing active labels.