Bug 30334

Summary:

Collect scope properties only when they are needed for completion

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	commit-queue: review-, pfeldman: commit-queue+

Yury Semikhatsky

Reported 2009-10-13 08:21:14 PDT

Collect scope properties only when they are needed for completion. There is no need need to serialize and pass them proactively along with call frames. This way all code collecting completion properties will live in InjectedScript.js

Attachments
patch (5.39 KB, patch) 2009-10-13 08:50 PDT, Yury Semikhatsky	commit-queue: review- pfeldman: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2009-10-13 08:50:40 PDT

Created attachment 41104 [details] patch

Pavel Feldman

Comment 2 2009-10-13 08:58:41 PDT

Looks good. Thanks for doing this!

WebKit Commit Bot

Comment 3 2009-10-13 09:55:02 PDT

Comment on attachment 41104 [details] patch Rejecting patch 41104 from review queue. pfeldman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

WebKit Commit Bot

Comment 4 2009-10-14 02:05:25 PDT

Pavel Feldman

Comment 5 2009-10-14 02:17:41 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r49557

Eric Seidel (no email)

Comment 6 2009-10-15 09:57:00 PDT

I've restarted the commit-queue, so it should notice the updated commitsers.py and you shouldn't have troubles like this again.

Note You need to log in before you can comment on or make changes to this bug.