Bug 30320

Summary:

Chrome Linux RTL select box displays arrow on wrong side

Product:

WebKit

Reporter:

Evan Martin <evan>

Component:

Forms

Assignee:

Evan Martin <evan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agl, dimich, eric, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
fixerate	none
fixerate	none
fix the bug and add a layout test	none
fix the bug and note it's covered by an existing test	dimich: review+, dimich: commit-queue-

Evan Martin

Reported 2009-10-12 18:09:51 PDT

See screenshot on http://code.google.com/p/chromium/issues/detail?id=23113 . The code is obviously wrong, and easy to fix.

Attachments
fixerate (1.21 KB, patch) 2009-10-12 18:16 PDT, Evan Martin	no flags	Details Formatted Diff Diff
fixerate (1.21 KB, patch) 2009-10-12 18:18 PDT, Evan Martin	no flags	Details Formatted Diff Diff
fix the bug and add a layout test (5.00 KB, patch) 2009-10-13 11:35 PDT, Evan Martin	no flags	Details Formatted Diff Diff
fix the bug and note it's covered by an existing test (1.35 KB, patch) 2009-10-13 13:29 PDT, Evan Martin	dimich: review+ dimich: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Evan Martin

Comment 1 2009-10-12 18:16:56 PDT

Created attachment 41077 [details] fixerate

Evan Martin

Comment 2 2009-10-12 18:17:20 PDT

Comment on attachment 41077 [details] fixerate I'm not sure what I need to do about pixel baselines. Any advice?

Evan Martin

Comment 3 2009-10-12 18:18:41 PDT

Created attachment 41079 [details] fixerate

Evan Martin

Comment 4 2009-10-13 11:35:38 PDT

Created attachment 41115 [details] fix the bug and add a layout test

Evan Martin

Comment 5 2009-10-13 11:38:52 PDT

Note that this test includes a .png baseline (for Mac) and some UTF-8 (for the Arabic text). Not sure those make it through the patch process. :(

Tony Chang

Comment 6 2009-10-13 12:04:54 PDT

If you use svn-create-patch, it will base64 encode the png into the patch file. Maybe there's something that can do the same for git diffs?

Evan Martin

Comment 7 2009-10-13 13:06:51 PDT

https://bugs.webkit.org/show_bug.cgi?id=26830 :~(

Evan Martin

Comment 8 2009-10-13 13:29:53 PDT

Created attachment 41122 [details] fix the bug and note it's covered by an existing test

Evan Martin

Comment 9 2009-10-13 13:31:50 PDT

Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test I realized that another test actually exhibits the problem too -- the baseline (in the Chrome tree) is wrong.

WebKit Commit Bot

Comment 10 2009-10-13 16:55:58 PDT

Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test Rejecting patch 41122 from review queue. dimich@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

Dmitry Titov

Comment 11 2009-10-13 16:58:52 PDT

Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test Commit Bot has old version of committers.py... heh. Fixing up the flags, will land manually.

Evan Martin

Comment 12 2009-10-13 17:21:13 PDT

I've seen committers add themselves to the commit bot script without review, too.

Dmitry Titov

Comment 13 2009-10-13 18:17:36 PDT

Landed: http://trac.webkit.org/changeset/49540

Eric Seidel (no email)

Comment 14 2009-10-15 10:02:43 PDT

Comment on attachment 41122 [details] fix the bug and note it's covered by an existing test I've restarted the commit-queue, so it should now correctly notice the update to committers.py and dimich@chromium.org should be able to set cq+ w/o problems. If you have any other issues, just drop me a line.

Note You need to log in before you can comment on or make changes to this bug.