Bug 30316

Summary: Build scripts: unchecked return value in call to system()
Product: WebKit Reporter: Mark Seaborn <mseaborn>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jorlow
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch v1
none
Die if gperf fails none

Mark Seaborn
Reported 2009-10-12 16:12:08 PDT
gperf is invoked via system() in the Perl build script WebCore/css/makevalues.pl, but the return value is not checked. This means that if gperf is not installed, makevalues.pl will not fail properly and will produce incomplete output. This causes build errors later on, and installing gperf does not fix the build because the build system is not aware that makevalues.pl's dependencies have changed. There is a similar unchecked system() call in WebCore/css/makegrammar.pl.
Attachments
Patch v1 (2.51 KB, patch)
2009-10-12 16:27 PDT, Mark Seaborn 		no flags
DetailsFormatted DiffDiff
Die if gperf fails (1.23 KB, patch)
2009-10-12 17:16 PDT, Mark Seaborn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Seaborn
Comment 1 2009-10-12 16:27:21 PDT
Created attachment 41066 [details] Patch v1
Mark Seaborn
Comment 2 2009-10-12 17:16:40 PDT
Created attachment 41068 [details] Die if gperf fails
WebKit Commit Bot
Comment 3 2009-10-14 14:41:08 PDT
Comment on attachment 41068 [details] Die if gperf fails Clearing flags on attachment: 41068 Committed r49584: <http://trac.webkit.org/changeset/49584>
WebKit Commit Bot
Comment 4 2009-10-14 14:41:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.