Bug 30305

Summary:

[Qt] DumpRenderTree has missing features and needs refactoring

Product:

WebKit

Reporter:

Andras Becsi <abecsi>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hausmann

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Refactoring LayoutTestController and related classes out of jsobjects, no functionality changes made yet.	none
Removed qtcreator's template user.pro file from the proposed patch	none
corrected coding style issues	none

Andras Becsi

Reported 2009-10-12 07:36:57 PDT

Created attachment 41042 [details] Refactoring LayoutTestController and related classes out of jsobjects, no functionality changes made yet. DumpRenderTree and its parts in QtWebKit are in a very bad shape. To implement missing features and fix annoying phonon related crashes and timeouts on the buildbot it needs some refactoring.

Attachments
Refactoring LayoutTestController and related classes out of jsobjects, no functionality changes made yet. (110 bytes, text/plain) 2009-10-12 07:36 PDT, Andras Becsi	no flags	Details
Removed qtcreator's template user.pro file from the proposed patch (75.34 KB, patch) 2009-10-12 07:44 PDT, Andras Becsi	no flags	Details Formatted Diff Diff
corrected coding style issues (75.33 KB, patch) 2009-10-13 07:44 PDT, Andras Becsi	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andras Becsi

Comment 1 2009-10-12 07:44:14 PDT

Created attachment 41043 [details] Removed qtcreator's template user.pro file from the proposed patch

Andras Becsi

Comment 2 2009-10-13 07:44:19 PDT

Created attachment 41102 [details] corrected coding style issues

WebKit Commit Bot

Comment 3 2009-10-13 15:51:21 PDT

Comment on attachment 41102 [details] corrected coding style issues Clearing flags on attachment: 41102 Committed r49519: <http://trac.webkit.org/changeset/49519>

WebKit Commit Bot

Comment 4 2009-10-13 15:51:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.