Bug 30298

Summary: Web Inspector: Use proper web view in inspector layout tests for windows.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch aroben: review+

Pavel Feldman
Reported 2009-10-12 02:01:53 PDT
Currently stub instance is being created instead of querying one from the frame. (I was going to submit it with the 'enable tests' change, but there is a blocking network-related issue there so I think it is worth submitting this independently).
Attachments
patch (2.86 KB, patch)
2009-10-12 02:10 PDT, Pavel Feldman 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-12 02:10:21 PDT
Created attachment 41026 [details] patch
Pavel Feldman
Comment 2 2009-10-12 13:39:26 PDT
There are no changes to semantics there. I just did not wire it to the proper webview instance in the first place, was creating a dummy object instead. Now all pieces are in place and we are ready to enable tests. Tests now work in DRT mode on windows, so we are all set. (The application/octet-stream road block has been resolved by itself).
Adam Roben (:aroben)
Comment 3 2009-10-12 20:02:22 PDT
Comment on attachment 41026 [details] patch r=me
Pavel Feldman
Comment 4 2009-10-13 01:28:58 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp Committed r49496
Note You need to log in before you can comment on or make changes to this bug.