Bug 30296

Summary:

[Qt] Add some initial autotests for QWebPage's ErrorPageExtention

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Tools / Tests

Assignee:

Antonio Gomes <tonikitoo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
landed in r49498 - patch 0.1 - error page extension	none

Antonio Gomes

Reported 2009-10-11 21:22:59 PDT

i just came up w/ some basic auto tests for errorpage extension. At this iteraction the autotest just sets an error page, checks if it is what is shown afterwards and if back/forward history is in the right state after the error handling. ps: i have noticed some problems w/ back/forward history that i will cover in another bug.

Attachments
landed in r49498 - patch 0.1 - error page extension (3.48 KB, patch) 2009-10-11 21:30 PDT, Antonio Gomes	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antonio Gomes

Comment 1 2009-10-11 21:30:29 PDT

Created attachment 41018 [details] landed in r49498 - patch 0.1 - error page extension

Simon Hausmann

Comment 2 2009-10-12 22:29:43 PDT

Comment on attachment 41018 [details] landed in r49498 - patch 0.1 - error page extension r=me > + ErrorPage(QWidget *parent = 0): QWebPage(parent) Please fix the * position before landing. Thanks for adding this test!

Antonio Gomes

Comment 3 2009-10-13 04:36:24 PDT

(In reply to comment #2) > (From update of attachment 41018 [details]) > r=me > > > + ErrorPage(QWidget *parent = 0): QWebPage(parent) > > Please fix the * position before landing. > > Thanks for adding this test! thx simon, landed in r49498

Antonio Gomes

Comment 4 2009-10-15 10:18:51 PDT

Comment on attachment 41018 [details] landed in r49498 - patch 0.1 - error page extension clearing r+ flag since patch has landed

Note You need to log in before you can comment on or make changes to this bug.