Bug 30289

Summary:

Enable SHARED_WORKERS for Chromium

Product:

WebKit

Reporter:

Andrew Wilson <atwilson>

Component:

WebCore JavaScript

Assignee:

Andrew Wilson <atwilson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	levin: review+, atwilson: commit-queue-

Andrew Wilson

Reported 2009-10-11 17:10:02 PDT

Need to turn on SHARED_WORKERS for Chromium, with the JS binding properly disabled.

Attachments
proposed patch (12.31 KB, patch) 2009-10-12 10:19 PDT, Andrew Wilson	levin: review+ atwilson: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wilson

Comment 1 2009-10-12 10:19:38 PDT

Created attachment 41049 [details] proposed patch

David Levin

Comment 2 2009-10-12 11:08:46 PDT

Comment on attachment 41049 [details] proposed patch > diff --git a/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp b/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp > #include "V8Index.h" > #include "V8Proxy.h" > #include "V8WorkerContextEventListener.h" > +#include "SharedWorker.h" > +#include "SharedWorkerContext.h" Nit: sort (Shared* before V8*)

Andrew Wilson

Comment 3 2009-10-13 16:40:48 PDT

Landed as r49526.

Note You need to log in before you can comment on or make changes to this bug.