Bug 302855
| Summary: | [GLIB] Move the run loop observer repeating logic to ActivityObserver | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Web Template Framework | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
This way neither the caller to notify() nor the callback need to check whether the observer is repeating or not. It's simpler, but also safer because ActivityObserver is refcounted and always protected while notify() is called, so we can safely check if it's repeating after the callback is called even if it's stopped by the callback.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/54242
EWS
Committed 303382@main (8aa34ebe7063): <https://commits.webkit.org/303382@main>
Reviewed commits have been landed. Closing PR #54242 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/165193416>