Bug 30264

Summary:

[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

WebCore JavaScript

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Unreviewed build fix for Windows (Cairo).	none
Fix bug.	eric: review+

David Levin

Reported 2009-10-09 15:18:33 PDT

This is due to http://trac.webkit.org/changeset/48884 which changed the parameters for a base class. There was a partial fix in http://trac.webkit.org/changeset/48904 but it missed a method. This currently causes worker-script-error.html to fail for users of v8.

Attachments
Unreviewed build fix for Windows (Cairo). (1.66 KB, patch) 2009-10-09 15:24 PDT, David Levin	no flags	Details Formatted Diff Diff
Fix bug. (2.13 KB, patch) 2009-10-09 15:28 PDT, David Levin	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

David Levin

Comment 1 2009-10-09 15:24:33 PDT

Created attachment 40967 [details] Unreviewed build fix for Windows (Cairo).

David Levin

Comment 2 2009-10-09 15:28:01 PDT

Comment on attachment 40967 [details] Unreviewed build fix for Windows (Cairo). Whoops... new tool problem.

David Levin

Comment 3 2009-10-09 15:28:31 PDT

Eric Seidel (no email)

Comment 4 2009-10-09 16:10:55 PDT

Comment on attachment 40968 [details] Fix bug. I guess v8 doesn't want to use the new param? :) rs=me.

David Levin

Comment 5 2009-10-09 17:28:10 PDT

Note You need to log in before you can comment on or make changes to this bug.