Bug 302506
| Summary: | Factor out two UnwindFunctor helper methods into an abstract base class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | JavaScriptCore | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
UnwindFunctor defined in Interpreter.cpp implements a couple of helper methods that are also useful while walking the stack during JSPI suspensions. However, there is no way to reuse those methods in JSPI because UnwindFunctor is only available in that compilation unit, and it's a concrete class implementing unwinding specifically to handle a thrown exception.
To avoid code duplication, it makes sense to move the helper methods into an abstract base class inherited by UnwindFunctor, that can also be inherited by the stack visitor functor in JSPI.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164690751>
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/53914
EWS
Committed 303119@main (d079117b77a9): <https://commits.webkit.org/303119@main>
Reviewed commits have been landed. Closing PR #53914 and removing active labels.