Bug 30231

Summary: isolated world tests were broken by recent signature change to LayoutTestController
Product: WebKit Reporter: Aaron Boodman <aa>
Component: PlatformAssignee: Aaron Boodman <aa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix bug.
none
Patch with better ChangeLog description none

Aaron Boodman
Reported 2009-10-08 12:14:57 PDT
LayoutTestController::evaluateInIsolatedWorld now requires two arguments.
Attachments
Fix bug. (14.46 KB, patch)
2009-10-08 12:19 PDT, Aaron Boodman 		no flags
DetailsFormatted DiffDiff
Patch with better ChangeLog description (14.82 KB, patch)
2009-10-08 12:28 PDT, Aaron Boodman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aaron Boodman
Comment 1 2009-10-08 12:19:47 PDT
Created attachment 40898 [details] Fix bug.
Aaron Boodman
Comment 2 2009-10-08 12:28:45 PDT
Created attachment 40899 [details] Patch with better ChangeLog description
Eric Seidel (no email)
Comment 3 2009-10-08 12:33:15 PDT
Comment on attachment 40899 [details] Patch with better ChangeLog description Looks fine. I think an optional last argument would have been slicker, but this is fine. :)
WebKit Commit Bot
Comment 4 2009-10-08 14:28:08 PDT
Comment on attachment 40899 [details] Patch with better ChangeLog description Clearing flags on attachment: 40899 Committed r49321: <http://trac.webkit.org/changeset/49321>
WebKit Commit Bot
Comment 5 2009-10-08 14:28:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.