Bug 30231

Summary: isolated world tests were broken by recent signature change to LayoutTestController
Product: WebKit Reporter: Aaron Boodman <aa>
Component: PlatformAssignee: Aaron Boodman <aa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix bug.
none
Patch with better ChangeLog description none

Description Aaron Boodman 2009-10-08 12:14:57 PDT
LayoutTestController::evaluateInIsolatedWorld now requires two arguments.
Comment 1 Aaron Boodman 2009-10-08 12:19:47 PDT
Created attachment 40898 [details]
Fix bug.
Comment 2 Aaron Boodman 2009-10-08 12:28:45 PDT
Created attachment 40899 [details]
Patch with better ChangeLog description
Comment 3 Eric Seidel (no email) 2009-10-08 12:33:15 PDT
Comment on attachment 40899 [details]
Patch with better ChangeLog description

Looks fine.  I think an optional last argument would have been slicker, but this is fine. :)
Comment 4 WebKit Commit Bot 2009-10-08 14:28:08 PDT
Comment on attachment 40899 [details]
Patch with better ChangeLog description

Clearing flags on attachment: 40899

Committed r49321: <http://trac.webkit.org/changeset/49321>
Comment 5 WebKit Commit Bot 2009-10-08 14:28:12 PDT
All reviewed patches have been landed.  Closing bug.