Bug 30229

Summary: [GTK] Exception control in EventSender is not correct
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   

Description Alejandro G. Castro 2009-10-08 12:00:39 PDT
In EventSender.cpp we are controlling the exceptions with lines like this one:

    g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));

We should use && instead of ||, and we could even leave (!*exception) if we can assure the parameter is always initialized.
Comment 1 Martin Robinson 2010-10-12 16:45:42 PDT
I think || is correct here. I'm cleaning up bugs, so I'll close this, but feel free to reopen it if I'm wrong.