Bug 30217

Summary: SVGURIReference Build problem for V8
Product: WebKit Reporter: John Gregg <johnnyg>
Component: WebCore Misc.Assignee: John Gregg <johnnyg>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
eric: review+, eric: commit-queue-
better patch
none
patch part 2 dglazkov: review+, atwilson: commit-queue-

John Gregg
Reported 2009-10-08 09:43:50 PDT
We don't need to directly build SVGURIReference in V8 - these properties are only accessed by inheritance; it used to be harmless but recent changes cause it to fail in compile.
Attachments
patch (1.58 KB, patch)
2009-10-08 09:55 PDT, John Gregg 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
better patch (1.59 KB, patch)
2009-10-08 09:58 PDT, John Gregg 		no flags
DetailsFormatted DiffDiff
patch part 2 (1.02 KB, patch)
2009-10-08 13:25 PDT, John Gregg 		dglazkov: review+
atwilson: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Gregg
Comment 1 2009-10-08 09:55:31 PDT
Created attachment 40881 [details] patch
John Gregg
Comment 2 2009-10-08 09:56:53 PDT
To be more specific, the fix is to not generate and compile in code directly from SVGURIReference.idl. The interface therein should only be used through derived classes.
Eric Seidel (no email)
Comment 3 2009-10-08 09:56:55 PDT
Comment on attachment 40881 [details] patch Tab in ChangeLog will cause commit to fail. Normally I don't put anything around urls, the [] seem superfluous to me. LGTM.
John Gregg
Comment 4 2009-10-08 09:58:10 PDT
Created attachment 40882 [details] better patch
John Gregg
Comment 5 2009-10-08 13:25:54 PDT
Created attachment 40906 [details] patch part 2 A second patch is required to fix this problem, as the .h file is still referenced.
Dimitri Glazkov (Google)
Comment 6 2009-10-08 13:30:39 PDT
Comment on attachment 40906 [details] patch part 2 r=me.
John Gregg
Comment 7 2009-10-08 14:17:13 PDT
Comment on attachment 40882 [details] better patch already applied.
Andrew Wilson
Comment 8 2009-10-08 14:20:05 PDT
Landed as r49319
Note You need to log in before you can comment on or make changes to this bug.