Bug 30214

Summary: [Qt] Windowless Plugins : Create Pixmap only when size changes.
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 20081    
Bug Blocks:    
Attachments:
Description Flags
Create X Pixmap only when size changes none

Description Girish Ramakrishnan 2009-10-08 09:02:10 PDT
Currently, a pixmap is created when the cliprect/windowrect changes.
Comment 1 Girish Ramakrishnan 2009-10-08 09:03:48 PDT
Created attachment 40876 [details]
Create X Pixmap only when size changes
Comment 2 Eric Seidel (no email) 2009-10-08 09:36:46 PDT
Comment on attachment 40876 [details]
Create X Pixmap only when size changes

Can plugins become windowed from being non-windowed?  The old code used to free m_drawable unconditionally, the new code only does so if the plugin is currently non-windowed.
Comment 3 Girish Ramakrishnan 2009-10-08 18:07:25 PDT
(In reply to comment #2)
> (From update of attachment 40876 [details])
> Can plugins become windowed from being non-windowed?  The old code used to free
> m_drawable unconditionally, the new code only does so if the plugin is
> currently non-windowed.

Good point. But no, they cannot switch from windowed to windowless (and vice-versa) after instantiation. The m_drawable check should have been inside the windowed case to start with i.e as it is in the patch.
Comment 4 Simon Hausmann 2009-10-09 04:11:05 PDT
Comment on attachment 40876 [details]
Create X Pixmap only when size changes
Comment 5 WebKit Commit Bot 2009-10-09 04:33:06 PDT
Comment on attachment 40876 [details]
Create X Pixmap only when size changes

Clearing flags on attachment: 40876

Committed r49386: <http://trac.webkit.org/changeset/49386>
Comment 6 WebKit Commit Bot 2009-10-09 04:33:10 PDT
All reviewed patches have been landed.  Closing bug.