| Summary: | Back out StringImpl::m_buffer to make MSVC happy | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jens Alfke <jens> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Jens Alfke <jens> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Major | CC: | jorlow | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows Vista | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 40831 [details]
removed unwanted space char
Created attachment 40832 [details]
now with changelog entry, duh
Comment on attachment 40832 [details] now with changelog entry, duh > + // const UChar m_fictitious_buffer[]; Whoever lands this, please delete this line. Created attachment 40833 [details]
remove commented declaration
Committed r49279: <http://trac.webkit.org/changeset/49279> Comment on attachment 40833 [details]
remove commented declaration
This was landed. Thank you Jens for the quick fix, and thank you Jeremy for the commit.
|
Created attachment 40830 [details] patch It's not worth having the variable-length-array m_buffer in StringImpl if MSVC doesn't handle it well. So this patch removes it and goes back to the hack of offsetting the base pointer by sizeof(StringImpl).