Bug 301842
| Summary: | TrackPrivateBase's label/language should return a String | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
TrackPrivateBase::label() and TrackPrivateBase::language() are returning an AtomString even though TrackPrivateBase is a ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr which is incompatible with AtomStrings (they must be deleted on the same thread they were creating).
We should make them return a String instead as the SourceBuffer/SourceBufferPrivate where TrackPrivateBase objects are created may no longer be on the main thread once we move to having the MediaPlayer back in the web process.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163911707>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/53327
EWS
Committed 302527@main (bd2c5cb034ca): <https://commits.webkit.org/302527@main>
Reviewed commits have been landed. Closing PR #53327 and removing active labels.