Bug 30174

Summary: Web Inspector: Wrap Database into ScriptObject in v8 bindings.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
abarth: review-
patch with comments addressed dglazkov: review+

Description Pavel Feldman 2009-10-07 09:52:51 PDT 
There is a TODO that should be replaced with the real implementation for database tab to work in Chromium.
Comment 1 Pavel Feldman 2009-10-07 09:58:42 PDT 
Created attachment 40801 [details]
patch
Comment 2 Adam Barth 2009-10-07 11:39:46 PDT 
Comment on attachment 40801 [details]
patch

Test?

+	Frame* frame = database->document()->frame();

This line has a tab.

What if frame() is null?

+    // FIXME: What if context.IsEmpty()?

You need to handle this case!

+    ScriptState* scriptState = frame->page()->inspectorController()->frontendScriptState();

What if page() is null?
Comment 3 Pavel Feldman 2009-10-07 11:50:11 PDT 
Created attachment 40809 [details]
patch with comments addressed
Comment 4 Dimitri Glazkov (Google) 2009-10-09 08:49:45 PDT 
Comment on attachment 40809 [details]
patch with comments addressed

r=me.

Pls add a line to ChangeLog entry explaining that there's no way to test this atm.
Comment 5 Pavel Feldman 2009-10-09 09:36:33 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/ScriptObjectQuarantine.cpp
Committed r49393