Summary: | REGRESSION (r49213): http/tests/plugins/local-geturl-from-remote.html is failing on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2009-10-07 08:08:06 PDT
Committed r49244: <http://trac.webkit.org/changeset/49244> Thanks for fixing this. How did the old code even compile? > How did the old code even compile?
It's operator comma, which is often used in for loops, but is universally available in fact:
for (i =0, j = 0; i != 1; i++, j++) {...}
The value of such an expression is the value of the last sub-expression. Unless I'm hallucinating, the ChangeLog comment here got it wrong (the condition was always false, not always true).
Wow, that's ridiculous. Thanks for explaining. (In reply to comment #3) > Unless > I'm hallucinating, the ChangeLog comment here got it wrong (the condition was > always false, not always true). The ChangeLog was wrong. |