Bug 30168

Summary: REGRESSION (r49213): http/tests/plugins/local-geturl-from-remote.html is failing on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 sam: review+

Description Adam Roben (:aroben) 2009-10-07 08:08:06 PDT
Created attachment 40788 [details]
Patch v1

r49213 contained a typo that is causing http/tests/plugins/local-geturl-from-remote.html to fail on Windows.
Comment 1 Adam Roben (:aroben) 2009-10-07 08:12:34 PDT
Committed r49244: <http://trac.webkit.org/changeset/49244>
Comment 2 Adam Barth 2009-10-07 08:58:35 PDT
Thanks for fixing this.  How did the old code even compile?
Comment 3 Alexey Proskuryakov 2009-10-07 21:23:43 PDT
> How did the old code even compile?

It's operator comma, which is often used in for loops, but is universally available in fact:

for (i =0, j = 0; i != 1; i++, j++) {...}

The value of such an expression is the value of the last sub-expression. Unless I'm hallucinating, the ChangeLog comment here got it wrong (the condition was always false, not always true).
Comment 4 Adam Barth 2009-10-07 21:26:17 PDT
Wow, that's ridiculous.  Thanks for explaining.
Comment 5 Adam Roben (:aroben) 2009-10-08 06:49:20 PDT
(In reply to comment #3)
> Unless
> I'm hallucinating, the ChangeLog comment here got it wrong (the condition was
> always false, not always true).

The ChangeLog was wrong.