Bug 30166

Summary: [Qt] Get rid of useless loadFailed signal in QGraphicsWebView
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit QtAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success none

Description Antonio Gomes 2009-10-07 07:40:48 PDT
In QWebView we have only loadFinished(bool success), but we tried to improved that for QGraphicsWebView introducing a new loadFailed signal.

This signal is now useless since error handling is being possible through somewhere else (ErrorPageExtension).

we should remove this loadFailed signal from QGraphicsWebView, making it compatible to QWebView in that sense.
Comment 1 Antonio Gomes 2009-10-07 07:44:50 PDT
Created attachment 40787 [details]
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success
Comment 2 Antonio Gomes 2009-10-07 08:24:54 PDT
r49245
Comment 3 Antonio Gomes 2009-10-07 08:25:50 PDT
Comment on attachment 40787 [details]
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success

clearing r+ flag since it landed.