Bug 30164

Summary: Video keeps playing after going fullscreen, then closing window
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: MediaAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Simon Fraser (smfr) 2009-10-07 07:28:34 PDT
Steps:
1. Play a video element
2. Go fullscreen
3. Exit fullscreen
4. Close window.

The video keeps playing (or, at least it did when I tried this on cuteoverload.com with Click To Flash installed).
Comment 1 Simon Fraser (smfr) 2009-10-07 11:30:45 PDT
May be related to bug 30119
Comment 2 Simon Fraser (smfr) 2009-10-12 09:07:27 PDT
Created attachment 41047 [details]
Patch
Comment 3 Darin Adler 2009-10-12 09:15:36 PDT
Comment on attachment 41047 [details]
Patch

> +    QTMovieView *movieView = [[self fullscreenWindow] movieView];
> +    [movieView setMovie:nil];

I would have done this on a single line without a local variable.

I would have included a comment, since it's not obvious that the reason this is critical is that it stops the movie from playing. Further, the comment could clarify whether this is a workaround for a QTMovieView bug or if it's simply a subtle aspect of the design of QTMovieView, as well.
Comment 4 Simon Fraser (smfr) 2009-10-12 09:28:29 PDT
I filed <rdar://problem/7295070> on the underlying problem.
Comment 5 Simon Fraser (smfr) 2009-10-12 09:30:13 PDT
http://trac.webkit.org/changeset/49443