Bug 30157

Summary: [Qt] Symbian SBSv2 .code segment is too big for linker
Product: WebKit Reporter: Janne Koskinen <koshuin>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, eric
Priority: P1 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
proposed fix for webcore.pro
none
proposed fix for webcore.pro take 2 none

Description Janne Koskinen 2009-10-07 01:16:32 PDT
Symbian's new build toolchain SBSv2 (Symbian Build System version 2) creates more code than the old SBSv1.
Toolchain has a fixed start address for .data segment that .code segment overlaps with in SBSv2 causing
the link stage to fail when building qtwebkit.dll.
Comment 1 Janne Koskinen 2009-10-07 01:21:48 PDT
Created attachment 40771 [details]
proposed fix for webcore.pro

Patch increases the base address of .data segment by passing linkeroption to RVCT's armlink.
Comment 2 Janne Koskinen 2009-10-07 02:29:26 PDT
Created attachment 40776 [details]
proposed fix for webcore.pro take 2

removed the test cases missing part from changelog.
Comment 3 WebKit Commit Bot 2009-10-07 03:04:57 PDT
Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Rejecting patch 40776 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11400 test cases.
storage/close-during-stress-test.html -> crashed

Exiting early after 1 failures. 9384 tests run.
481.84s total testing time

9383 test cases (99%) succeeded
1 test case (<1%) crashed
6 test cases (<1%) had stderr output
Comment 4 Simon Hausmann 2009-10-07 03:48:18 PDT
Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Overriding the bot here, this patch cannot possibly have affected the failing test :)
Comment 5 WebKit Commit Bot 2009-10-07 03:58:23 PDT
Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Clearing flags on attachment: 40776

Committed r49239: <http://trac.webkit.org/changeset/49239>
Comment 6 WebKit Commit Bot 2009-10-07 03:58:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2009-10-07 09:39:21 PDT
(In reply to comment #4)
> (From update of attachment 40776 [details])
> Overriding the bot here, this patch cannot possibly have affected the failing
> test :)

Agreed.  Although when that happens we need to be sure to file bugs about the flakey tests. :)  (Which is my job, don't get me wrong.  But if somehow I don't notice a flakey test like this in the future, feel free/encouraged to ping me about it or CC me on the bug.)  Filed bug 30172.