Bug 301469
| Summary: | webkitscmpy.program.command shouldn't hardcode "Canonical link" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=301470 | ||
| Bug Depends on: | |||
| Bug Blocks: | 266028 | ||
Sam Sneddon [:gsnedders]
As part of bug 266028, we need to migrate everything to supporting actual git trailers.
We have:
```
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py
79: NO_FILTER_RES = [re.compile(r' Canonical link:'), re.compile(r' git-svn-id:')]
```
I'm not totally sure what the goal of this is, because making the list empty still has all the tests passing, and trying to run e.g. `git-webkit log --hash` just makes the functionality seem pretty broken.
Thinking about this in abstract, I don't know when it expects it to be indented v. when not, as for `git-webkit log` this depends on the `--format` (etc.) option.
Either way, we should at the least look at `identifier_template` rather than hardcoding this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163410599>