Bug 30132 – Make beforeload work with link/xml-stylesheet elements

• Component: CSS
• Status: RESOLVED FIXED

[Dave Hyatt]

Make beforeload work with stylesheet loads.

[Dave Hyatt]

Created attachment 40737 [details]
Add support for beforeload for stylesheet loads

[Dave Hyatt]

Created attachment 40738 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 40738 [details]
Patch

It would be good to add comments/tests for the bug fixes you made to ProcessingInstruction and HTMLLinkElement. It would also be good to add a test that uses ProcessingInstruction!

r=me

[Dave Hyatt]

Created attachment 40743 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 40743 [details]
Patch

>  void ProcessingInstruction::setData(const String& data, ExceptionCode&)
>  {
> -    int oldLength = m_data.length();
>      m_data = data;
> -    document()->textRemoved(this, 0, oldLength);
> +    checkStyleSheet();
>  }

Why don't we need to call textRemoved anymore? Was it buggy? Is there anything we need to do for PIs that are not stylesheets? You should address at least some of these questions in your ChangeLog.

You should add your new test to your ChangeLogs.

r=me

[Dave Hyatt]

Fixed in r49208.