| Summary: | 1-char fix for obviously reverse condition. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dmitry Titov
2009-10-05 15:49:58 PDT
Created attachment 40669 [details]
Proposed fix.
Comment on attachment 40669 [details]
Proposed fix.
It would be even better if we had some test that was failing because of this backward code. This was harmless. Why?
r=me
the only place it was called from was destructor of ScriptCachedFramedata - so the RetainedPtr was destructed anyways and a window was released. The only difference was that gcController().garbageCollectSoon(); was not invoked, as WebKit usually tries to do after releasing a DOMWindow. sorry, should be 'after releasing JSDOMWindow'. |