Bug 30100

Summary: 1-char fix for obviously reverse condition.
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed fix. darin: review+

Dmitry Titov
Reported 2009-10-05 15:49:58 PDT
the patch is forthcoming.
Attachments
Proposed fix. (1.01 KB, patch)
2009-10-05 15:54 PDT, Dmitry Titov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-10-05 15:54:09 PDT
Created attachment 40669 [details] Proposed fix.
Darin Adler
Comment 2 2009-10-05 15:56:42 PDT
Comment on attachment 40669 [details] Proposed fix. It would be even better if we had some test that was failing because of this backward code. This was harmless. Why? r=me
Dmitry Titov
Comment 3 2009-10-05 16:03:41 PDT
the only place it was called from was destructor of ScriptCachedFramedata - so the RetainedPtr was destructed anyways and a window was released. The only difference was that gcController().garbageCollectSoon(); was not invoked, as WebKit usually tries to do after releasing a DOMWindow.
Dmitry Titov
Comment 4 2009-10-05 16:36:58 PDT
sorry, should be 'after releasing JSDOMWindow'.
Dmitry Titov
Comment 5 2009-10-05 17:07:17 PDT
landed: http://trac.webkit.org/changeset/49134
Note You need to log in before you can comment on or make changes to this bug.