Bug 30087

Summary: Web Inspector: Do not call nodeTitleInfo twice + followup fixes for r49101.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: bweinstein, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
patch timothy: review+

Description Pavel Feldman 2009-10-05 12:36:15 PDT
First call into nodeTitleInfo is only used for getting proper hasChildren value.
Comment 1 Pavel Feldman 2009-10-05 12:41:16 PDT
Created attachment 40651 [details]
Comment 2 Brian Weinstein 2009-10-05 12:58:36 PDT
Looks good here, but I'm not a reviewer. Sorry about missing those two changes from this -> node. :-(.

- Empty () in the ChangeLog looks a little weird.
Comment 3 Timothy Hatcher 2009-10-05 14:43:57 PDT
Comment on attachment 40651 [details]

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +        ():

We should figure out why htis happens and fix it.
Comment 4 Pavel Feldman 2009-10-06 05:03:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
Committed r49173