Bug 300701
| Summary: | [libpas] Build fails with libc implementations that lack execinfo.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | bmalloc | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=102946 https://bugs.webkit.org/show_bug.cgi?id=173531 https://bugs.webkit.org/show_bug.cgi?id=300735 |
||
Adrian Perez
For example, attempting to build with Musl:
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:52:10: fatal error: execinfo.h: No such file or directory
52 | #include <execinfo.h>
| ^~~~~~~~~~~~
compilation terminated.
Also, uCLibc supports being configured without support for backtrace()/execinfo.h, as per bug #102946
The right thing to do would be to check whether the backtrace() function and execinfo.h header are available. For example Source/WTF/wtf/StackTrace.h does exactly that: checks for HAVE(BACKTRACE) || HAVE(BACKTRACE_SYMBOLS), which is defined in Source/WTF/wtf/PlatformHave.h -- libpas should have similar checks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/52300
EWS
Committed 301539@main (c78f2b76d86c): <https://commits.webkit.org/301539@main>
Reviewed commits have been landed. Closing PR #52300 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/162668131>