Bug 30069

Summary: [Qt] Remove precompiled header from JavaScriptCore compilation to allow autonomous compilation.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch v0.2 none

Jocelyn Turcotte
Reported 2009-10-05 03:51:06 PDT
JavaScriptCore.pro includes its pch from WebKit/qt/WebKit_pch.h, which displays a warning when compiling an extracted standalone JavaScriptCore. This is the simple solution, needed at least while we need JavaScriptCore to be compiled out of WebKit inside Qt. It would be possible to create a pch especially for JavaScriptCore to keep the compilation time reduction, however this may polute the directory (or any of the reason why WebKit_pch.h is currently in WebKit/qt/) Please have a thought about it while reviewing.
Attachments
Patch (970 bytes, patch)
2009-10-05 03:52 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch v0.2 (993 bytes, patch)
2009-10-05 03:57 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2009-10-05 03:52:56 PDT
Created attachment 40618 [details] Patch
Jocelyn Turcotte
Comment 2 2009-10-05 03:57:00 PDT
Created attachment 40620 [details] Patch v0.2 Better changelog message
Simon Hausmann
Comment 3 2009-10-05 14:57:04 PDT
Comment on attachment 40620 [details] Patch v0.2 r=me, that header isn't needed anymore for this .pro file.
WebKit Commit Bot
Comment 4 2009-10-05 16:19:04 PDT
Comment on attachment 40620 [details] Patch v0.2 Clearing flags on attachment: 40620 Committed r49128: <http://trac.webkit.org/changeset/49128>
WebKit Commit Bot
Comment 5 2009-10-05 16:19:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.