Bug 30064

Summary:

Syntax Highlighting CSS shouldn't be duplicated

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

Web Inspector (Deprecated)

Assignee:

Brian Weinstein <bweinstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
CSS Refactor	bweinstein: commit-queue-
Fix extra typo + Add bug link	timothy: review-, bweinstein: commit-queue-
Also WebKit.qrc	timothy: review+, bweinstein: commit-queue-

Brian Weinstein

Reported 2009-10-04 21:38:56 PDT

There should be a common CSS file that handles the styling of syntax highlighting.

Attachments
CSS Refactor (8.74 KB, patch) 2009-10-04 21:49 PDT, Brian Weinstein	bweinstein: commit-queue-	Details Formatted Diff Diff
Fix extra typo + Add bug link (9.43 KB, patch) 2009-10-04 22:01 PDT, Brian Weinstein	timothy: review- bweinstein: commit-queue-	Details Formatted Diff Diff
Also WebKit.qrc (9.99 KB, patch) 2009-10-04 22:22 PDT, Brian Weinstein	timothy: review+ bweinstein: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2009-10-04 21:49:15 PDT

Created attachment 40609 [details] CSS Refactor

Joseph Pecoraro

Comment 2 2009-10-04 21:56:29 PDT

Excellent =). A few tiny things: 1. When this gets reviewed can you fix a typo in SourceFrame.js? In the comments above all that styleText there is a typo "(becuase it is a user agent sheet.)". "because" is spelled wrong. Could fix that? 2. Forgot a link to this bug in the ChangeLog? prepare-Changelog --bug #### will auto fill that part in for you.

Brian Weinstein

Comment 3 2009-10-04 21:58:57 PDT

(In reply to comment #2) > Excellent =). A few tiny things: > > 1. When this gets reviewed can you fix a typo in SourceFrame.js? In the > comments above all that styleText there is a typo "(becuase it is a user agent > sheet.)". "because" is spelled wrong. Could fix that? > I can take care of that as part of this patch. It looks like highlight is misspelled about 10 times elsewhere in that file, so I'll put that in a different patch. > 2. Forgot a link to this bug in the ChangeLog? prepare-Changelog --bug #### > will auto fill that part in for you. Yeah, I forgot to link to the bug. Will do.

Brian Weinstein

Comment 4 2009-10-04 22:01:30 PDT

Created attachment 40610 [details] Fix extra typo + Add bug link

Timothy Hatcher

Comment 5 2009-10-04 22:12:45 PDT

Comment on attachment 40610 [details] Fix extra typo + Add bug link Needs added to WebKit.qrc for Qt.

Brian Weinstein

Comment 6 2009-10-04 22:22:19 PDT

Created attachment 40611 [details] Also WebKit.qrc

Brian Weinstein

Comment 7 2009-10-04 22:37:41 PDT

Commited in http://trac.webkit.org/changeset/49082.

Note You need to log in before you can comment on or make changes to this bug.