| Summary: | [Gtk][Layout tests] Generate results for editing tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2009-10-04 11:20:35 PDT
Created attachment 40598 [details]
Generated results
This patch adds generated test results for about 350 tests. Only these tests produce 'rendering-equal' results to those from the mac port.
With 'rendering-equal' phrase, these guarantees are meant:
- Equal render objects are created in the same places (not necessarrily in the exact same position and with exact same size)
- These objects have equal CSS attributes (borders, color etc.)
- In the case of text runs, they contain equal text
- Equal caret and selection attributes dump
Basically, they're semantically equal, there can be differences in the size and position of render objects because of different font metrics.
Tests that do not produce 'rendering-equal' results should be listed in another bug, examined and then fixed if fixable or added as generated if they're not fixable and acceptable as such.
Comment on attachment 40598 [details]
Generated results
It is very sad that so many of these are render tree dumps instead of being dumpAsText (but that's not your fault).
rubber-stamp=me.
Comment on attachment 40598 [details]
Generated results
Setting cq+, since Zan is not a committer.
Comment on attachment 40598 [details] Generated results Clearing flags on attachment: 40598 Committed r49192: <http://trac.webkit.org/changeset/49192> All reviewed patches have been landed. Closing bug. |