Bug 30044

Summary: [Qt] EventSender::keyDown() cannot send function-key events.
Product: WebKit Reporter: Jakub Wieczorek <jwieczorek>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
eric: review+
patch none

Description Jakub Wieczorek 2009-10-03 07:26:11 PDT
This is required for the fast/events/keydown-function-keys.html layout test.
Comment 1 Jakub Wieczorek 2009-10-03 07:28:51 PDT
Created attachment 40573 [details]
Comment 2 Eric Seidel (no email) 2009-10-05 09:20:31 PDT
Comment on attachment 40573 [details]

Looks OK, but the ChangeLog should say what layout test this fixes.
Comment 3 Jakub Wieczorek 2009-10-05 09:59:26 PDT
Created attachment 40638 [details]

(In reply to comment #2)
> (From update of attachment 40573 [details])
> Looks OK, but the ChangeLog should say what layout test this fixes.

The patch itself does not fix the above mentioned test failure because there's one more bug in Qt DRT that makes the test fail: https://bugs.webkit.org/show_bug.cgi?id=30043

I've also added ' && functionKey <= 35' to the assertion, just in case.
Comment 4 Simon Hausmann 2009-10-05 14:47:20 PDT
Comment on attachment 40638 [details]

r=me, but please also make a patch that removes the skipped test from the list. Or in the future you could do that in one single change :-)
Comment 5 WebKit Commit Bot 2009-10-05 15:37:41 PDT
Comment on attachment 40638 [details]

Clearing flags on attachment: 40638

Committed r49118: <http://trac.webkit.org/changeset/49118>
Comment 6 WebKit Commit Bot 2009-10-05 15:37:44 PDT
All reviewed patches have been landed.  Closing bug.