Bug 30043

Summary: [Qt] Fix the EventSender::keyDown() implementation
Product: WebKit Reporter: Jakub Wieczorek <jwieczorek>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Jakub Wieczorek 2009-10-03 07:16:37 PDT 
Currently it only triggers a key press event, while it should also send a key release event. That's also what other ports do.
Comment 1 Jakub Wieczorek 2009-10-03 07:17:41 PDT 
Created attachment 40571 [details]
patch
Comment 2 Jakub Wieczorek 2009-10-03 07:21:37 PDT 
Created attachment 40572 [details]
patch

Add the missing ChangeLog.
Comment 3 Jakub Wieczorek 2009-10-03 07:56:52 PDT 
Created attachment 40574 [details]
patch

Fixed the style.
Comment 4 Eric Seidel (no email) 2009-10-05 09:19:31 PDT 
Comment on attachment 40574 [details]
patch

Please list what layout tests this affects.  If it doesn't affect any, please explain why, or add one which it affects. :)
Comment 5 Jakub Wieczorek 2009-10-05 10:46:23 PDT 
(In reply to comment #4)
> (From update of attachment 40574 [details])
> Please list what layout tests this affects.  If it doesn't affect any, please
> explain why, or add one which it affects. :)

Similarly to https://bugs.webkit.org/show_bug.cgi?id=30044, it also addresses the fast/events/keydown-function-keys.html failure. I'm not 100% sure if it fixed any other tests but it doesn't seem so. Later on, I will be going through the tests that use it and that are skipped currently to see if there are any that are fine now.
Comment 6 Simon Hausmann 2009-10-05 13:58:51 PDT 
Comment on attachment 40574 [details]
patch

Thanks!
Comment 7 WebKit Commit Bot 2009-10-06 04:35:15 PDT 
Comment on attachment 40574 [details]
patch

Clearing flags on attachment: 40574

Committed r49166: <http://trac.webkit.org/changeset/49166>
Comment 8 WebKit Commit Bot 2009-10-06 04:35:19 PDT 
All reviewed patches have been landed.  Closing bug.