Bug 300158
| Summary: | Update SQLiteDatabase::prepareStatement() to return a std::unique_ptr instead of an std::expected | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Update SQLiteDatabase::prepareStatement() to return a std::unique_ptr instead of an std::expected. Returning a std::expected containing a SQLiteStatement doesn't play nice with Safer CPP static analysis and reports false positives. Using a `std::unique_ptr<SQLiteStatement>` makes static analysis happy without having to make the code more verbose.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/51798
EWS
Committed 301020@main (a6e7d5013931): <https://commits.webkit.org/301020@main>
Reviewed commits have been landed. Closing PR #51798 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/161983876>
Radar WebKit Bug Importer
<rdar://problem/161984037>