Bug 30006

Summary: [GStreamer] Unnecessary checks for Messages types in callbacks
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Sebastian Dröge (slomo)
Reported 2009-10-02 01:54:32 PDT
The EOS/StateChange/Error callbacks check the message type but they can only be called with that exact message. The check should be removed ;) Also instead of 3-4 different callbacks for all messages types it might make sense to only use a single one, with a switch over the message types.
Attachments
proposed patch (7.13 KB, patch)
2009-10-14 06:16 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2009-10-14 06:16:34 PDT
Created attachment 41158 [details] proposed patch
Sebastian Dröge (slomo)
Comment 2 2009-10-14 06:47:07 PDT
Looks good to me
WebKit Commit Bot
Comment 3 2009-10-15 06:10:09 PDT
Comment on attachment 41158 [details] proposed patch Clearing flags on attachment: 41158 Committed r49621: <http://trac.webkit.org/changeset/49621>
WebKit Commit Bot
Comment 4 2009-10-15 06:10:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.