Bug 29998

Summary: [GStreamer] Should probably scale video frames to requested size
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 29997    
Bug Blocks:    
Attachments:
Description Flags
scale-video.diff
gustavo: review-
scale-video.diff none

Sebastian Dröge (slomo)
Reported 2009-10-02 01:23:46 PDT
Hi, currently the MediaPlayer only scales the video frames to the p-a-r but keeps everything else as is. I think it should additionally scale the frames to fit the requested size as good as possible (while keeping the p-a-r). With requested size I mean what gets passed to MediaPlayerPrivate::setSize(). Important here is, that you really really should make sure that a) the par is kept and b) both width and height are <= the requested size
Attachments
scale-video.diff (2.48 KB, patch)
2009-10-12 01:24 PDT, Sebastian Dröge (slomo) 		gustavo: review-
DetailsFormatted DiffDiff
scale-video.diff (2.81 KB, patch)
2009-10-12 06:43 PDT, Sebastian Dröge (slomo) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sebastian Dröge (slomo)
Comment 1 2009-10-12 01:24:00 PDT
Created attachment 41023 [details] scale-video.diff Patch on top of the one from bug #29997.
Gustavo Noronha (kov)
Comment 2 2009-10-12 05:29:01 PDT
Comment on attachment 41023 [details] scale-video.diff Nice =). So, what I said in #29997 regarding coding style mostly applies to this one too. Since this one is basically a follow-up to that one, I'll say r- for now.
Sebastian Dröge (slomo)
Comment 3 2009-10-12 06:43:22 PDT
Created attachment 41038 [details] scale-video.diff
Gustavo Noronha (kov)
Comment 4 2009-10-12 06:59:31 PDT
Comment on attachment 41038 [details] scale-video.diff Thanks!
WebKit Commit Bot
Comment 5 2009-10-12 07:34:46 PDT
Comment on attachment 41038 [details] scale-video.diff Clearing flags on attachment: 41038 Committed r49439: <http://trac.webkit.org/changeset/49439>
WebKit Commit Bot
Comment 6 2009-10-12 07:34:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.