Bug 29998

Summary:

[GStreamer] Should probably scale video frames to requested size

Product:

WebKit

Reporter:

Sebastian Dröge (slomo) <slomo>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

29997

Bug Blocks:

Attachments:

Description	Flags
scale-video.diff	gustavo: review-
scale-video.diff	none

Description Sebastian Dröge (slomo) 2009-10-02 01:23:46 PDT

Hi,
currently the MediaPlayer only scales the video frames to the p-a-r but keeps everything else as is. I think it should additionally scale the frames to fit the requested size as good as possible (while keeping the p-a-r). With requested size I mean what gets passed to MediaPlayerPrivate::setSize().

Important here is, that you really really should make sure that a) the par is kept and b) both width and height are <= the requested size

Comment 1 Sebastian Dröge (slomo) 2009-10-12 01:24:00 PDT

Created attachment 41023 [details]
scale-video.diff

Patch on top of the one from bug #29997.

Comment 2 Gustavo Noronha (kov) 2009-10-12 05:29:01 PDT

Comment on attachment 41023 [details]
scale-video.diff

Nice =). So, what I said in #29997 regarding coding style mostly applies to this one too. Since this one is basically a follow-up to that one, I'll say r- for now.

Comment 3 Sebastian Dröge (slomo) 2009-10-12 06:43:22 PDT

Created attachment 41038 [details]
scale-video.diff

Comment 4 Gustavo Noronha (kov) 2009-10-12 06:59:31 PDT

Comment on attachment 41038 [details]
scale-video.diff

Thanks!

Comment 5 WebKit Commit Bot 2009-10-12 07:34:46 PDT

Comment on attachment 41038 [details]
scale-video.diff

Clearing flags on attachment: 41038

Committed r49439: <http://trac.webkit.org/changeset/49439>

Comment 6 WebKit Commit Bot 2009-10-12 07:34:50 PDT

All reviewed patches have been landed.  Closing bug.