Bug 29960

Summary: [GTK] media player: better mute support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, slomo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Description Philippe Normand 2009-10-01 06:27:42 PDT 
As pointed out by slomo :)

MediaPlayerPrivateGStreamer.cpp in setMuted() it should really use
the "mute" property of playbin2. That keeps the current volume and just
mutes the audio ;)
Comment 1 Philippe Normand 2009-10-01 06:40:33 PDT 
Created attachment 40438 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2009-10-01 08:59:58 PDT 
Comment on attachment 40438 [details]
proposed patch

Very good.
Comment 3 WebKit Commit Bot 2009-10-01 10:17:21 PDT 
Comment on attachment 40438 [details]
proposed patch

Clearing flags on attachment: 40438

Committed r48980: <http://trac.webkit.org/changeset/48980>
Comment 4 WebKit Commit Bot 2009-10-01 10:17:26 PDT 
All reviewed patches have been landed.  Closing bug.