Bug 29960

Summary: [GTK] media player: better mute support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, slomo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Philippe Normand
Reported 2009-10-01 06:27:42 PDT
As pointed out by slomo :) MediaPlayerPrivateGStreamer.cpp in setMuted() it should really use the "mute" property of playbin2. That keeps the current volume and just mutes the audio ;)
Attachments
proposed patch (2.22 KB, patch)
2009-10-01 06:40 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2009-10-01 06:40:33 PDT
Created attachment 40438 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2009-10-01 08:59:58 PDT
Comment on attachment 40438 [details] proposed patch Very good.
WebKit Commit Bot
Comment 3 2009-10-01 10:17:21 PDT
Comment on attachment 40438 [details] proposed patch Clearing flags on attachment: 40438 Committed r48980: <http://trac.webkit.org/changeset/48980>
WebKit Commit Bot
Comment 4 2009-10-01 10:17:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.