Bug 299597
| Summary: | [CMake] Use imported targets in the GLib find-module | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
It would be nicer to use imported targets in Source/cmake/FindGLIB.cmake
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/51395
EWS
Committed 300628@main (68a9c2d8e124): <https://commits.webkit.org/300628@main>
Reviewed commits have been landed. Closing PR #51395 and removing active labels.
Diego Pino
Patch broke Ubuntu 22.04 WPEWebKit build bot.
https://build.webkit.org/#/builders/1060/builds/13432
```
In file included from /home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-74.cpp:1:
/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/Source/WebCore/platform/mediastream/gstreamer/DesktopPortal.cpp:26:10: fatal error: gio/gunixfdlist.h: No such file or directory
26 | #include <gio/gunixfdlist.h>
| ^~~~~~~~~~~~~~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/51563
EWS
Committed 300750@main (a4ac8823d8de): <https://commits.webkit.org/300750@main>
Reviewed commits have been landed. Closing PR #51563 and removing active labels.
Adrian Perez
There are still some uses of GLIB_INCLUDE_DIRS and GIO_[UNIX_]INCLUDE_DIRS, reopening to tackle those
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/52107
EWS
Committed 301384@main (489ec3327c1a): <https://commits.webkit.org/301384@main>
Reviewed commits have been landed. Closing PR #52107 and removing active labels.