Bug 29952

Summary:

Move RedirectScheduler to its own file

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

29947

Attachments:

Description	Flags
Patch v1	none
Patch v1	darin: review+

Description Adam Barth 2009-09-30 22:44:57 PDT

forthcoming

Comment 1 Adam Barth 2009-09-30 22:46:31 PDT

Created attachment 40424 [details]
Patch v1

Comment 2 Adam Barth 2009-09-30 22:52:57 PDT

Created attachment 40425 [details]
Patch v1

Comment 3 Darin Adler 2009-10-01 10:47:55 PDT

Comment on attachment 40425 [details]
Patch v1

Normally in cases like this I start the new file with an svn copy of the large file I am extracting it from.

I am disappointed we had to make so many FrameLoader internals public in order to break this out! (But that was a comment on the earlier patch really, not this one.)

> +        void schedule(PassOwnPtr<ScheduledRedirection> redirection);

Should leave our argument here.

I think the RedirectScheduler is not well factored with respect to the frame loader. It contains more of the logic than I would like that has nothing to do with scheduling per se, which is why we end up exporting so many new functions from FrameLoader.

But this is a noble effort, lets keep going and see where it leads.

Comment 4 Adam Barth 2009-10-01 13:05:37 PDT

> I am disappointed we had to make so many FrameLoader internals public in order
> to break this out! (But that was a comment on the earlier patch really, not
> this one.)

Yeah, me too.  I'm hoping this will be a somewhat temporary situation.  Once I get a better understanding of FrameLoader, I hope to move some of this back (in particular, the parts that care about isComplete).

Comment 5 Adam Barth 2009-10-02 00:57:58 PDT

Committed r49012: <http://trac.webkit.org/changeset/49012>