Bug 29952

Summary: Move RedirectScheduler to its own file
Product: WebKit Reporter: Adam Barth <abarth>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29947    
Attachments:
Description Flags
Patch v1
none
Patch v1 darin: review+

Adam Barth
Reported 2009-09-30 22:44:57 PDT
forthcoming
Attachments
Patch v1 (40.55 KB, patch)
2009-09-30 22:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (40.65 KB, patch)
2009-09-30 22:52 PDT, Adam Barth 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-09-30 22:46:31 PDT
Created attachment 40424 [details] Patch v1
Adam Barth
Comment 2 2009-09-30 22:52:57 PDT
Created attachment 40425 [details] Patch v1
Darin Adler
Comment 3 2009-10-01 10:47:55 PDT
Comment on attachment 40425 [details] Patch v1 Normally in cases like this I start the new file with an svn copy of the large file I am extracting it from. I am disappointed we had to make so many FrameLoader internals public in order to break this out! (But that was a comment on the earlier patch really, not this one.) > + void schedule(PassOwnPtr<ScheduledRedirection> redirection); Should leave our argument here. I think the RedirectScheduler is not well factored with respect to the frame loader. It contains more of the logic than I would like that has nothing to do with scheduling per se, which is why we end up exporting so many new functions from FrameLoader. But this is a noble effort, lets keep going and see where it leads.
Adam Barth
Comment 4 2009-10-01 13:05:37 PDT
> I am disappointed we had to make so many FrameLoader internals public in order > to break this out! (But that was a comment on the earlier patch really, not > this one.) Yeah, me too. I'm hoping this will be a somewhat temporary situation. Once I get a better understanding of FrameLoader, I hope to move some of this back (in particular, the parts that care about isComplete).
Adam Barth
Comment 5 2009-10-02 00:57:58 PDT
Committed r49012: <http://trac.webkit.org/changeset/49012>
Note You need to log in before you can comment on or make changes to this bug.