Bug 29940

Summary: [V8] HTMLAudio, HTMLImageElement, and HTMLOptionElement are constructable.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
none
Make things less constructable, v2.
none
Make things less constructable, v3. fishd: review+

Dimitri Glazkov (Google)
Reported 2009-09-30 16:07:36 PDT
Created attachment 40406 [details] Patch v1 Due to my refactoring earlier this year, I accidentally made HTML(Audio|Image|Op tion)Element properties constructable. This patch mimics JSC's behavior and crea tes a distinction between them and just plain window.Audio, Image, and Option.[A[B
Attachments
Patch v1 (18.15 KB, patch)
2009-09-30 16:07 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Make things less constructable, v2. (18.21 KB, patch)
2009-09-30 16:15 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Make things less constructable, v3. (18.27 KB, patch)
2009-09-30 16:23 PDT, Dimitri Glazkov (Google) 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-09-30 16:09:36 PDT
Comment on attachment 40406 [details] Patch v1 Missing bug URL :)
Dimitri Glazkov (Google)
Comment 2 2009-09-30 16:15:12 PDT
Created attachment 40407 [details] Make things less constructable, v2.
Dimitri Glazkov (Google)
Comment 3 2009-09-30 16:22:31 PDT
Comment on attachment 40407 [details] Make things less constructable, v2. Real thing coming up.
Dimitri Glazkov (Google)
Comment 4 2009-09-30 16:23:12 PDT
Created attachment 40408 [details] Make things less constructable, v3.
Dimitri Glazkov (Google)
Comment 5 2009-09-30 20:00:10 PDT
Landed as http://trac.webkit.org/changeset/48955.
Note You need to log in before you can comment on or make changes to this bug.