Bug 29936

Summary: [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: DOMAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, fishd, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch updating Chromium ifdefs fishd: review+, fishd: commit-queue-

Kenneth Russell
Reported 2009-09-30 14:52:30 PDT
In https://bugs.webkit.org/show_bug.cgi?id=29664 certain Chromium-specific #ifdefs were put under PLATFORM(SKIA). These should have been PLATFORM(CHROMIUM). Patch attached. Note that this abstraction mechanism for factoring out the internals of the GraphicsContext3D could be used on all platforms.
Attachments
Patch updating Chromium ifdefs (1.70 KB, patch)
2009-09-30 15:00 PDT, Kenneth Russell 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2009-09-30 15:00:53 PDT
Created attachment 40402 [details] Patch updating Chromium ifdefs
Darin Fisher (:fishd, Google)
Comment 2 2009-09-30 21:49:24 PDT
Comment on attachment 40402 [details] Patch updating Chromium ifdefs > Index: WebCore/ChangeLog ... > +2009-09-30 Kenneth Russell <kbr@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h > + https://bugs.webkit.org/show_bug.cgi?id=29936 oops... the tab stop there will prevent this from being committed by the commit-queue. i'll commit this manually, but please watch out for tabs in the future. r=me
Darin Fisher (:fishd, Google)
Comment 3 2009-10-05 16:58:21 PDT
Landed as http://trac.webkit.org/changeset/49132
Note You need to log in before you can comment on or make changes to this bug.