Bug 29915

Summary: Buildfix for platforms using JSVALUE32
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, eric, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch ggaren: review+, ggaren: commit-queue-

Csaba Osztrogonác
Reported 2009-09-30 02:33:27 PDT
http://trac.webkit.org/changeset/48895 brakes build if using JSVALUE32. - In emit_op_add and emitSlow_op_add missing the declaration of types variable. - In emit_op_add there are two typo (and some unnecessary code).
Attachments
proposed patch (2.92 KB, patch)
2009-09-30 02:38 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch (2.97 KB, patch)
2009-09-30 04:22 PDT, Csaba Osztrogonác 		ggaren: review+
ggaren: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2009-09-30 02:38:49 PDT
Created attachment 40352 [details] proposed patch eg. ARM and Qt port on Windows use JSVALUE32 now. Patch tested on ARM.
Csaba Osztrogonác
Comment 2 2009-09-30 04:22:07 PDT
Created attachment 40359 [details] proposed patch patch updated: "unnecessary" replaced with "unreachable" in ChangeLog In additional tested with QtWebKit-win.
Geoffrey Garen
Comment 3 2009-09-30 11:21:12 PDT
Comment on attachment 40359 [details] proposed patch r=me
WebKit Commit Bot
Comment 4 2009-09-30 11:23:58 PDT
Comment on attachment 40359 [details] proposed patch Rejecting patch 40359 from review queue. ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Geoffrey Garen
Comment 5 2009-09-30 11:27:10 PDT
Committed revision 48938.
Eric Seidel (no email)
Comment 6 2009-09-30 15:00:58 PDT
Geoff needs to be added to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py as a reviewer. I'll take care of it.
Eric Seidel (no email)
Comment 7 2009-09-30 15:08:58 PDT
I've added Geoff to the list of reviewers. bugzilla-tool (and thus the commit-queue) will recognize him as a valid reviewer now: http://trac.webkit.org/changeset/48949 If I've missed any other reviewers or committers they should feel encouraged to add themselves to that file w/o review.
Note You need to log in before you can comment on or make changes to this bug.