|Summary:||Buildfix for platforms using JSVALUE32|
|Product:||WebKit||Reporter:||Csaba Osztrogonác <ossy>|
|Severity:||Normal||CC:||barraclough, eric, ggaren|
|Version:||528+ (Nightly build)|
Description Csaba Osztrogonác 2009-09-30 02:33:27 PDT
Comment 1 Csaba Osztrogonác 2009-09-30 02:38:49 PDT
Created attachment 40352 [details] proposed patch eg. ARM and Qt port on Windows use JSVALUE32 now. Patch tested on ARM.
Comment 2 Csaba Osztrogonác 2009-09-30 04:22:07 PDT
Created attachment 40359 [details] proposed patch patch updated: "unnecessary" replaced with "unreachable" in ChangeLog In additional tested with QtWebKit-win.
Comment 3 Geoffrey Garen 2009-09-30 11:21:12 PDT
Comment on attachment 40359 [details] proposed patch r=me
Comment 4 WebKit Commit Bot 2009-09-30 11:23:58 PDT
Comment on attachment 40359 [details] proposed patch Rejecting patch 40359 from review queue. email@example.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 5 Geoffrey Garen 2009-09-30 11:27:10 PDT
Committed revision 48938.
Comment 6 Eric Seidel (no email) 2009-09-30 15:00:58 PDT
Geoff needs to be added to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py as a reviewer. I'll take care of it.
Comment 7 Eric Seidel (no email) 2009-09-30 15:08:58 PDT
I've added Geoff to the list of reviewers. bugzilla-tool (and thus the commit-queue) will recognize him as a valid reviewer now: http://trac.webkit.org/changeset/48949 If I've missed any other reviewers or committers they should feel encouraged to add themselves to that file w/o review.