Summary: | [Chromium] Incorrect conditions in WebCore.gyp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Hawk <hawk> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, yaar | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Chris Hawk
2009-09-29 17:31:30 PDT
Created attachment 40336 [details]
Patch the collapses the two condition sections into one
Comment on attachment 40336 [details] Patch the collapses the two condition sections into one Forgot to click the "patch" checkbox. Tools like "bugzilla-tool post-diff" will do all that for you. Also your ChangeLog should really have the bug number in it. prepare-ChangeLog --bug will do that. This is covered in http://webkit.org/coding/contributing.html Comment on attachment 40336 [details] Patch the collapses the two condition sections into one This looks great, except: > + Fix for conditionals in the WebCore gyp file, which contained two separate > + 'conditions' values for the webcore target. The first entry was ignored, > + resulting in some missine defines. Need bug URL. Created attachment 40385 [details]
Previous patch + bug URL
Comment on attachment 40385 [details]
Previous patch + bug URL
r=me.
Comment on attachment 40385 [details] Previous patch + bug URL Clearing flags on attachment: 40385 Committed r48940: <http://trac.webkit.org/changeset/48940> All reviewed patches have been landed. Closing bug. |