Bug 29898 – update-webkit --chromium fails to set .gclient file

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Yaar Schnitman]

The error codes of exec calls in the update-webkit-chromium perl scripts are not captured correctly.

[Yaar Schnitman]

Created attachment 40327 [details]
minor error handling changes

exec(...) doesn't return the error codes we expect. reverted to using system(...)

[David Kilzer (:ddkilzer)]

Comment on attachment 40327 [details]
minor error handling changes

> diff --git a/WebKitTools/Scripts/update-webkit b/WebKitTools/Scripts/update-webkit

>  } elsif (isChromium()) {
> -    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die;
> +    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!;
>  } elsif (isAppleWinWebKit()) {
>      system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0 or die;
>  }

Someday we may be able to use something other than "perl" here.  See Bug 29656 Comment #8.

r=me

[WebKit Commit Bot]

Comment on attachment 40327 [details]
minor error handling changes

Clearing flags on attachment: 40327

Committed r48916: <http://trac.webkit.org/changeset/48916>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.