Bug 29898

Summary: update-webkit --chromium fails to set .gclient file
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit Misc.Assignee: Yaar Schnitman <yaar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
minor error handling changes none

Description Yaar Schnitman 2009-09-29 14:58:46 PDT
The error codes of exec calls in the update-webkit-chromium perl scripts are not captured correctly.
Comment 1 Yaar Schnitman 2009-09-29 15:01:44 PDT
Created attachment 40327 [details]
minor error handling changes

exec(...) doesn't return the error codes we expect. reverted to using system(...)
Comment 2 David Kilzer (:ddkilzer) 2009-09-29 18:01:59 PDT
Comment on attachment 40327 [details]
minor error handling changes

> diff --git a/WebKitTools/Scripts/update-webkit b/WebKitTools/Scripts/update-webkit

>  } elsif (isChromium()) {
> -    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die;
> +    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!;
>  } elsif (isAppleWinWebKit()) {
>      system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0 or die;
>  }

Someday we may be able to use something other than "perl" here.  See Bug 29656 Comment #8.

r=me
Comment 3 WebKit Commit Bot 2009-09-29 18:46:37 PDT
Comment on attachment 40327 [details]
minor error handling changes

Clearing flags on attachment: 40327

Committed r48916: <http://trac.webkit.org/changeset/48916>
Comment 4 WebKit Commit Bot 2009-09-29 18:46:45 PDT
All reviewed patches have been landed.  Closing bug.