Bug 29897

Summary: REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the inspector is already open when the profile completes
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: mnaganov, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch oliver: review+

Description Oliver Hunt 2009-09-29 14:26:49 PDT 
When using the entry in the develop menu to start a profile, the profile is not inserted into the profile view unless the inspector has already been opened.

To reproduce:
1. Go to a site with js
2. Develop | Start profiling JavaScript
3. wait a bit
4. Develop | Stop profiling JavaScript

Result:
The inspector opens to the profiler pane, but doesn't display the profile
Comment 1 Pavel Feldman 2009-09-29 14:51:45 PDT 
Created attachment 40326 [details]
patch

Regression introduced in r47821. Thanks for the report.
Comment 2 Oliver Hunt 2009-09-29 14:55:15 PDT 
Comment on attachment 40326 [details]
patch

how does this interact with alloc profiles?  eg. if the first profile was an alloc profile would it display?
Comment 3 Pavel Feldman 2009-09-29 14:59:42 PDT 
(In reply to comment #2)
> (From update of attachment 40326 [details])
> how does this interact with alloc profiles?  eg. if the first profile was an
> alloc profile would it display?

This obviously needs to be resolved when we add different profile flavors (heap profiles are behind the flag now). Adding a FIXME note there and landing.
Comment 4 Pavel Feldman 2009-09-29 15:10:22 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ProfilesPanel.js
Committed r48907