| Summary: | [Gtk][Layout tests] Generate results for dom tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, zecke | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 40377 [details]
Generated results
Adds generated results and enables now passing tests in the Skipped.
The NP_Initialize messages are coming from the totem plugin? If that is the case it is not too good to put that into our expected result. I think the Qt folks added a way to filter out such messages. Created attachment 41002 [details]
Generated results
The previous patch was malformed, it was adding many files that weren't actually wanted, or required.
This one now adds only generated results for tests that we are removing from the Skipped.
Comment on attachment 41002 [details]
Generated results
LGTM.
Comment on attachment 41002 [details] Generated results Clearing flags on attachment: 41002 Committed r49652: <http://trac.webkit.org/changeset/49652> All reviewed patches have been landed. Closing bug. |
Created attachment 40320 [details] Comparisment of Gtk and Mac render trees Currently, 15 tests in dom/ directory need to have results generated: dom/xhtml/level3/core/canonicalform08.xhtml dom/xhtml/level3/core/canonicalform09.xhtml dom/xhtml/level3/core/documentgetinputencoding03.xhtml dom/xhtml/level3/core/entitygetinputencoding02.xhtml dom/xhtml/level3/core/entitygetxmlversion02.xhtml dom/xhtml/level3/core/nodegetbaseuri05.xhtml dom/xhtml/level3/core/nodegetbaseuri07.xhtml dom/xhtml/level3/core/nodegetbaseuri09.xhtml dom/xhtml/level3/core/nodegetbaseuri10.xhtml dom/xhtml/level3/core/nodegetbaseuri11.xhtml dom/xhtml/level3/core/nodegetbaseuri15.xhtml dom/xhtml/level3/core/nodegetbaseuri17.xhtml dom/xhtml/level3/core/nodegetbaseuri18.xhtml dom/xhtml/level3/core/nodelookupnamespaceuri01.xhtml dom/xhtml/level3/core/nodelookupprefix19.xhtml Attached is the comparisment of Mac and Gtk render trees. Analysis: Differences, if any, appear beacuse of the different font metrics.