Bug 29887

Summary:

Qt WebKit is sending the policy changed error for any QNetworkReply error.

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, tonikitoo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Fix handling of QNetworkReply errors	none

Kenneth Rohde Christiansen

Reported 2009-09-29 10:19:16 PDT

Created attachment 40307 [details] Fix handling of QNetworkReply errors Patch to fix the handling of QNetworkReply errors.

Attachments
Fix handling of QNetworkReply errors (2.95 KB, patch) 2009-09-29 10:19 PDT, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-09-29 12:20:02 PDT

Comment on attachment 40307 [details] Fix handling of QNetworkReply errors Why wouldn't this check be inside sendResponseIfNeeded()? I really don't know this code at all, but the "ifNeeded" makes me feel like maybe that function should have this kind of check. It's a little strange to conditionally call "ifNeeded" functions.

Kenneth Rohde Christiansen

Comment 2 2009-09-29 12:23:29 PDT

(In reply to comment #1) > (From update of attachment 40307 [details]) > Why wouldn't this check be inside sendResponseIfNeeded()? > > I really don't know this code at all, but the "ifNeeded" makes me feel like > maybe that function should have this kind of check. It's a little strange to > conditionally call "ifNeeded" functions. Yes, I actually thought about that, but I wasn't sure. Let's see if Simon has some comments.

Kenneth Rohde Christiansen

Comment 3 2009-09-29 15:13:28 PDT

Comment on attachment 40307 [details] Fix handling of QNetworkReply errors Landed in 48900.

Antonio Gomes

Comment 4 2009-10-27 10:37:07 PDT

(In reply to comment #1) > (From update of attachment 40307 [details]) > Why wouldn't this check be inside sendResponseIfNeeded()? > > I really don't know this code at all, but the "ifNeeded" makes me feel like > maybe that function should have this kind of check. It's a little strange to > conditionally call "ifNeeded" functions. i agree this "if" should move to inside that *ifneeded* function.

Kenneth Rohde Christiansen

Comment 5 2009-10-27 10:45:11 PDT

That is already done.

Note You need to log in before you can comment on or make changes to this bug.