Bug 29840

Summary: 4 layout tests failed by r48861
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix 4 layout test failures by r48861 eric: review+

Fumitoshi Ukai
Reported 2009-09-29 00:49:07 PDT
4 layout tests failed by r48861. fast/dom/prototype-inheritance-2.html -> failed fast/dom/prototype-inheritance.html -> failed fast/dom/Window/window-properties.html -> failed fast/js/global-constructors.html -> failed
Attachments
Fix 4 layout test failures by r48861 (3.98 KB, patch)
2009-09-29 01:49 PDT, Fumitoshi Ukai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2009-09-29 01:49:10 PDT
Created attachment 40289 [details] Fix 4 layout test failures by r48861
Eric Seidel (no email)
Comment 2 2009-09-29 01:53:20 PDT
Comment on attachment 40289 [details] Fix 4 layout test failures by r48861 Looks fine. Go ahead and commit. :)
Eric Seidel (no email)
Comment 3 2009-09-29 01:53:41 PDT
The commit-queue can't handle tree fixes yet, so this has to be landed by hand.
Fumitoshi Ukai
Comment 4 2009-09-29 01:58:39 PDT
(In reply to comment #2) > (From update of attachment 40289 [details]) > Looks fine. Go ahead and commit. :) Thanks! Landed as r48863.
Sam Weinig
Comment 5 2009-09-29 10:45:54 PDT
Why is it ok for WebSocket to return undefined. This seems like it will give the impression that we support the feature.
Fumitoshi Ukai
Comment 6 2009-09-29 18:56:39 PDT
(In reply to comment #5) > Why is it ok for WebSocket to return undefined. This seems like it will give > the impression that we support the feature. I believe a web developer checks the feature by checking it is undefined or not. If the feature is supported, it should be object (or function). If there any way to clear property (custom constructor) from DOMWindow at all in runtime, I'll do it.
Note You need to log in before you can comment on or make changes to this bug.