Bug 29840 - 4 layout tests failed by r48861
Summary: 4 layout tests failed by r48861
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 00:49 PDT by Fumitoshi Ukai
Modified: 2009-09-29 18:56 PDT (History)
2 users (show)

See Also:

Attachments
Fix 4 layout test failures by r48861 (3.98 KB, patch)
2009-09-29 01:49 PDT, Fumitoshi Ukai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-09-29 00:49:07 PDT 
4 layout tests failed by r48861.

fast/dom/prototype-inheritance-2.html -> failed
fast/dom/prototype-inheritance.html -> failed
fast/dom/Window/window-properties.html -> failed
fast/js/global-constructors.html -> failed
Comment 1 Fumitoshi Ukai 2009-09-29 01:49:10 PDT 
Created attachment 40289 [details]
Fix 4 layout test failures by r48861
Comment 2 Eric Seidel (no email) 2009-09-29 01:53:20 PDT 
Comment on attachment 40289 [details]
Fix 4 layout test failures by r48861

Looks fine.  Go ahead and commit. :)
Comment 3 Eric Seidel (no email) 2009-09-29 01:53:41 PDT 
The commit-queue can't handle tree fixes yet, so this has to be landed by hand.
Comment 4 Fumitoshi Ukai 2009-09-29 01:58:39 PDT 
(In reply to comment #2)
> (From update of attachment 40289 [details])
> Looks fine.  Go ahead and commit. :)

Thanks!
Landed as r48863.
Comment 5 Sam Weinig 2009-09-29 10:45:54 PDT 
Why is it ok for WebSocket to return undefined.  This seems like it will give the impression that we support the feature.
Comment 6 Fumitoshi Ukai 2009-09-29 18:56:39 PDT 
(In reply to comment #5)
> Why is it ok for WebSocket to return undefined.  This seems like it will give
> the impression that we support the feature.

I believe a web developer checks the feature by checking it is undefined or not.
If the feature is supported, it should be object (or function).

If there any way to clear property (custom constructor) from DOMWindow at all in runtime, I'll do it.