Bug 298178
| Summary: | [WebXR][OpenXR] Add API to get consent required/optional features of WebKitXRPermissionRequest | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | Keywords: | DoNotImportToRadar |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=297450 | ||
Fujii Hironori
[WebXR][OpenXR] Add API to get concent required/optional features of WebKitXRPermissionRequest
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/49447
EWS
Committed 299591@main (91c148a27b2e): <https://commits.webkit.org/299591@main>
Reviewed commits have been landed. Closing PR #49447 and removing active labels.
Fujii Hironori
Lots of warning after 299591@main with clang++.
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:351:5: error: pasting formed '" ""viewer"', an invalid preprocessing token
351 | APPEND_FEATURE(WEBKIT_XR_SESSION_FEATURES_VIEWER, "viewer");
| ^
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:350:35: note: expanded from macro 'APPEND_FEATURE'
350 | g_string_append(str, (" " ## name) + !(count++));
| ^
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:352:5: error: pasting formed '" ""local"', an invalid preprocessing token
352 | APPEND_FEATURE(WEBKIT_XR_SESSION_FEATURES_LOCAL, "local");
| ^
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:350:35: note: expanded from macro 'APPEND_FEATURE'
350 | g_string_append(str, (" " ## name) + !(count++));
| ^
(...)
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
349 | g_string_append(str, " viewer" + !(count++));
| ~~~~~~~~~~^~~~~~~~~~~~
/usr/include/glib-2.0/glib/gstring.h:269:26: note: expanded from macro 'g_string_append'
269 | (__builtin_constant_p (val) ? \
| ^~~
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: note: use array indexing to silence this warning
349 | g_string_append(str, " viewer" + !(count++));
| ^
| & [
/usr/include/glib-2.0/glib/gstring.h:269:26: note: expanded from macro 'g_string_append'
269 | (__builtin_constant_p (val) ? \
| ^
/home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
349 | g_string_append(str, " viewer" + !(count++));
| ~~~~~~~~~~^~~~~~~~~~~~
/usr/include/glib-2.0/glib/gstring.h:271:35: note: expanded from macro 'g_string_append'
271 | const char * const __val = (val); \
(...)
Fujii Hironori
Re-opening for pull request https://github.com/WebKit/WebKit/pull/50424
EWS
Committed 299670@main (d65a76dbf3a5): <https://commits.webkit.org/299670@main>
Reviewed commits have been landed. Closing PR #50424 and removing active labels.